Checkout operation (currently) doesn't honor executable bit even if FS would

denio7 / egit

Automatically exported from code.google.com/p/egit

0 stars 0 forks source link

Checkout operation (currently) doesn't honor executable bit even if FS would #3

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Clone egit.git using the Eclipse Import wizard.  The resulting checkout has
the wrong executable flag on the make_jgit.sh script.

This probably will be fixed once we get the checkout/merge code rewritten
to use DirCacheBuilder and can correctly handle the executable mode through
the FS instance.

Original issue reported on code.google.com by shawn.pe...@gmail.com on 25 Aug 2008 at 3:57

GoogleCodeExporter commented 9 years ago

Original comment by shawn.pe...@gmail.com on 25 Aug 2008 at 5:00

Added labels: Component-EGit-Core, Component-JGit

GoogleCodeExporter commented 9 years ago

This features requires Java 6 or newer. With a Java 5 VM the execute bit is 
silently
ignored. We could have a warning that the user can mark as do not remind me 
again.

Original comment by robin.ro...@gmail.com on 25 Aug 2008 at 10:42

GoogleCodeExporter commented 9 years ago

Worse is happening to me with the Egit nightlies, it chmod -x executable files 
when I
do a commit.

Original comment by ismail.d...@gmail.com on 18 Mar 2009 at 11:52

GoogleCodeExporter commented 9 years ago

Any updates? It keeps doing chmod -x with java 1.6.0_13-b03 and jgit 
v0.4.0.375.gb5cf.

Original comment by justnull...@gmail.com on 20 May 2009 at 4:50

GoogleCodeExporter commented 9 years ago

Works here (new clone from Eclipse 3.4 on Ubuntu 9.04, same result with jgit 
cmd and
build 1.6.0_13-b03/any another 1.6 jvm)

-rwxr--r-- 1 me me  2236 2009-05-20 19:07 make_jgit.sh
-rw-r--r-- 1 me me  6536 2009-05-20 19:10 README

Original comment by robin.ro...@gmail.com on 20 May 2009 at 5:14

GoogleCodeExporter commented 9 years ago

still drops execute bit for group and other

-rwxr--r-- 1 me me  2236 2009-05-20 19:07 make_jgit.sh

here is simple test run.

#did a chmod on machine A 
chmod 755 cgi-bin/test.cgi
#pushed it to S3
git commit;jgit push 
#... mode change 100644 => 100755 cgi-bin/test.cgi ...
# so far so good

# clone from S3 on machine B
jgit clone  amazon-s3://...
ls -l cgi-bin/test.cgi
#-rwxr--r-- 1 root root   135 2009-05-21 13:18 cgi-bin/test.cgi

chmod o+x cgi-bin/test.cgi 
git status
#nothing to commit (working directory clean)
chmod o-x cgi-bin/test.cgi 
git status
#nothing to commit (working directory clean)
# aren't these two chmods mutually exclusive?
chmod u-x cgi-bin/test.cgi 
git status
#modified:   cgi-bin/test.cgi
#so it picks up chmod changes sometimes

Clearly this is not working properly, since when i add/remove exec bit to 
other(or
group) git thinks that nothing is changed which is obviously a bug.

Original comment by justnull...@gmail.com on 21 May 2009 at 5:39

GoogleCodeExporter commented 9 years ago

I opened Issue 92 for the extended problem described in comment #6. The original
problem has been fixed, but one might want more.

Original comment by robin.ro...@gmail.com on 22 May 2009 at 7:48

GoogleCodeExporter commented 9 years ago

Thank you, will wait for java 7.
For now I am using pre/post-commit hooks that chmod all *.cgi to 755 (the 
pre-commit
is needed to make sure that the file system and repository is in sync otherwise 
git
merge fails when the modes are out of sync.

Original comment by justnull...@gmail.com on 26 May 2009 at 3:16