Git tries to decorate files on non-git project

[GoogleCodeExporter]

I use several Version Control systems for different projects I work on, but
they all share the same Eclipse install, therefore each and all have the
same list of plugins installed -- including egit.

Now, even when I'm working on a workspace with a single project, and that
project is not Git-managed, egit still tries to perform operations. I often
see, for example, the message "Git resource decorator triggered".

I also find lots of error messages in the error log about git failing to
decorate files, etc. I paste one below, for instance (again, taken from a
non-git project, only project in the workspace).

****

org.eclipse.core.internal.resources.ResourceException: Resource
'/myproject/classes/com/proj/SomeFile.class' is not local.
at org.eclipse.core.internal.resources.Resource.checkLocal(Resource.java:329)
at
org.eclipse.core.internal.resources.Resource.checkAccessibleAndLocal(Resource.ja
va:201)
at
org.eclipse.core.internal.resources.Resource.setSessionProperty(Resource.java:16
32)
at
org.spearce.egit.ui.internal.decorators.GitResourceDecorator.clearDecorationStat
e(GitResourceDecorator.java:203)
at
org.spearce.egit.ui.internal.decorators.GitResourceDecorator$ResCL$1.visit(GitRe
sourceDecorator.java:148)
at org.eclipse.core.internal.resources.Resource$2.visit(Resource.java:106)
at
org.eclipse.core.internal.resources.Resource$1.visitElement(Resource.java:58)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:81)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIter
ator.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator
.java:126)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:68)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:104)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:95)
at
org.spearce.egit.ui.internal.decorators.GitResourceDecorator$ResCL.run(GitResour
ceDecorator.java:144)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Original issue reported on code.google.com by zorze...@gmail.com on 15 Apr 2009 at 10:19

[GoogleCodeExporter]

What version of eGit was this? I don't see the 
org.spearce.egit.ui.internal.decorators.GitResourceDecorator 
any more. I see a GitLightweightDecorator though - maybe it's changed?

That said, I do see a 'filter' error message coming up against the current 
version

No property tester contributes a property projectPersistentProperty 
org.eclipse.team.core.repository to type 
class org.eclipse.core.internal.resources.Project

java.lang.Throwable: forcePluginActivation: false, receiver: P/Test
at 
org.eclipse.core.internal.expressions.TypeExtensionManager.getProperty(TypeExten
sionManager.java:115)
at 
org.eclipse.core.internal.expressions.TestExpression.evaluate(TestExpression.jav
a:96)
at 
org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeE
xpression.java:53)
at 
org.eclipse.core.internal.expressions.AdaptExpression.evaluate(AdaptExpression.j
ava:91)
at 
org.eclipse.ui.internal.dialogs.RegistryPageContributor.failsEnablement(Registry
PageContributor.java:260)
at 
org.eclipse.ui.internal.dialogs.RegistryPageContributor.isApplicableTo(RegistryP
ageContributor.java:209)
at 
org.eclipse.ui.internal.dialogs.PropertyPageContributorManager.getApplicableCont
ributors(PropertyPageContri
butorManager.java:199)
at 
org.eclipse.ui.dialogs.PropertyDialogAction.hasPropertyPagesFor(PropertyDialogAc
tion.java:104)
at 
org.eclipse.ui.dialogs.PropertyDialogAction.isApplicableForSelection(PropertyDia
logAction.java:146)
at 
org.eclipse.ui.dialogs.PropertyDialogAction.isApplicableForSelection(PropertyDia
logAction.java:126)
at 
org.eclipse.jdt.ui.actions.OpenViewActionGroup.fillContextMenu(OpenViewActionGro
up.java:266)
at 
org.eclipse.jdt.ui.actions.NavigateActionGroup.fillContextMenu(NavigateActionGro
up.java:105)
at 
org.eclipse.jdt.internal.ui.actions.CompositeActionGroup.fillContextMenu(Composi
teActionGroup.java:72)
at 
org.eclipse.jdt.internal.ui.packageview.PackageExplorerActionGroup.fillContextMe
nu(PackageExplorerActionGr
oup.java:287)
at 
org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart.menuAboutToShow(Pack
ageExplorerPart.java:780)
at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:335)
at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:466)
at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:462)
at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:488)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:235)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1204)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1228)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1209)
at org.eclipse.swt.widgets.Menu.menuWillOpen(Menu.java:654)
at org.eclipse.swt.widgets.Display.windowDelegateProc(Display.java:4308)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:205)
at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:1680)
at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:1723)
at org.eclipse.swt.widgets.Display.windowDelegateProc(Display.java:4318)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:3925)
at org.eclipse.swt.widgets.Display.applicationProc(Display.java:3946)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
at 
org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:101)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2874)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2393)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2357)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2209)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:499)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:492)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at 
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java
:113)
at 
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(Ecli
pseAppLauncher.java:110)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLau
ncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:556)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:511)
at org.eclipse.equinox.launcher.Main.run(Main.java:1284)
at org.eclipse.equinox.launcher.Main.main(Main.java:1260)

Original comment by alex.ble...@gmail.com on 18 Apr 2009 at 7:05

[GoogleCodeExporter]

It was valid, but I'm closing as invalid since this was reported against a 
rougly two
month old version where the relevant code has been rewritten.

Regardig Alex's comment that should be it's own report provided it can be 
amended with
enough information for me to understand it and relate it to EGit.

Original comment by robin.ro...@gmail.com on 18 Apr 2009 at 9:49

• Changed state: Invalid

[GoogleCodeExporter]

I tested it against the "tentative" build, and, indeed, I don't seem to be able 
to
reproduce the problem. I'm hoping the release will be made soon...

Original comment by zorze...@gmail.com on 20 Apr 2009 at 5:13