denis-stepanov / advent

Vent intrusive TV ads
GNU General Public License v3.0
14 stars 1 forks source link

Treat jingles without entry/exit flags as non-actionable instead of always actionable #40

Closed denis-stepanov closed 2 years ago

denis-stepanov commented 2 years ago

Current naming convention for jingles says:

Binary flags in decimal
    0x1 - Jingle starts the ads (0 if unknown)
    0x2 - Jingle ends the ads (0 if unknown)

This contains ambiguity, as if we improve out knowledge from "unknown" to "no", the flag will not change. The tool is resolving the ambiguity by interpreting 0 as "unknown" only if none of the two flags has been set. In this case it then behaves as if both flags have been set to 1. So, _0 in the jingle name would be equivalent to _3.

Actually, the original intention was that any jingle would trigger a change in TV state, so the default should be 1. It is thus suggested to change (0 if unknown) recommendation to (1 if unsure) and adapt the tool so that it gives no particular treatment to _0 case. Hence, tracks with _0 flags will become non-actionable (i.e., they would be recognized but result in no action on TV).

The existing database on jingles should not be affected by this, as. at the moment of writing, there are no jingles with _0 flags.