deniscerri / ytdlnis

Android Video/Audio Downloader app using yt-dlp
GNU General Public License v3.0
4.02k stars 142 forks source link

[BUG] --no-check-certificates doesn't work on non-YouTube sites but works in DLnis terminal #350

Closed Omegaplexx closed 11 months ago

Omegaplexx commented 11 months ago

Describe the bug Hello! I tried to download a video from Twitter, or X (or Twix as I like to say).

When I add an extra command template with "--no-check-certificates" in it, I still get SSL: CERTIFICATE_VERIFY_FAILED and for some reason this argument duplicates to that long download command everytime I add an extra template.

Screenshot_20231207-040928_YTDLnis Screenshot_20231207-040935_YTDLnis

"If YTDLnis can't download the video, then there must be a problem with yt-dlp" I thought to myself and was wrong.

Screenshot_20231207-045159_YTDLnis It works.

Even simple "yt-dlp link --no-check-certificates" works perfectly. Screenshot_20231207-035547_YTDLnis

To Reproduce

  1. Find a Twitter video in browser and click "Share".
  2. Choose YTDLnis and wait.

Expected behavior It should work cuz it's yt-dlp GUI. Can you fix this bug please?

(please complete the following information):

zaednasr commented 11 months ago

You are doing two distinct actions. In GUI you are fetching data but in terminal you are simply downloading. Adding an extra command and hitting update doesnt do anything. That command is there waiting to be used when you start the download. Data fetching is built in the app.

Looks like there is something wrong with -j in twitter so just hit download, it will still work. The app doesnt have to fetch data beforehand.

Omegaplexx commented 11 months ago

@zaednasr

just hit download, it will still work.

Thank you, it worked!

Looks like there is something wrong with -j in twitter

Just checked in terminal if -j option works on Twitter and VK (russian video site) and it does only with --no-check-certificates. Can you make a setting that adds that parameter in YTDLnis data fetching command? I cannot even paste a link in a field on YTDLnis Home screen without it bc I'll get an error.