deniscerri / ytdlnis

Android Video/Audio Downloader app using yt-dlp
GNU General Public License v3.0
3.62k stars 123 forks source link

[BUG] Cannot download the video with different errors #413

Closed ksi closed 6 months ago

ksi commented 6 months ago

Describe the bug I've updated to 1.7.3 and now cannot download videos in audio format. I get different errors. See an example below. It looks like some escaping is now broken.

To Reproduce I tried to download a video in audio only mode: https://www.youtube.com/watch?v=3d-FNAgCqbg And got the following error from the first try:

 -N "3" --cookies "/data/user/0/com.deniscerri.ytdl/cache/cookies.txt" --trim-filenames "202" --no-mtime --sponsorblock-remove "music_offtopic,selfpromo,preview,sponsor,intro,outro,filler,interaction" " " --parse-metadata "uploader:(?P<uploader>.+)(?: - Topic)$" --parse-metadata "%(uploader,channel,creator,artist|null)s:%(uploader)s" --parse-metadata "artist:(?P<meta_album_artist>[^,]+)" --parse-metadata "%(album_artist,meta_album_artist,uploader)s:%(album_artist)s" --parse-metadata "%(release_year,release_date>%Y,upload_date>%Y)s:%(meta_date)s" --parse-metadata "%(album,title)s:%(meta_album)s" -x --audio-format "m4a" -P "/data/user/0/com.deniscerri.ytdl/cache/downloads/811" -S "hasaud,acodec:aac,ext:m4a" --embed-metadata --embed-thumbnail --convert-thumbnails "jpg" -o "%(uploader,channel).30B-%(title).170B.%(ext)s" "https://www.youtube.com/watch?v=3d-FNAgCqbg"

ERROR: [generic] '' is not a valid URL. Set --default-search "ytsearch" (or run  yt-dlp "ytsearch:" ) to search YouTube

Then tried to redownload it form the error queue and the the following:

 -N "3" --cookies "/data/user/0/com.deniscerri.ytdl/cache/cookies.txt" --trim-filenames "202" --no-mtime --sponsorblock-remove "music_offtopic,selfpromo,preview,sponsor,intro,outro,filler,interaction" --replace-in-metadata "title" ".+" "Как родителям "выжить рядом с подростком" " --replace-in-metadata "uploader" ".+" "Dima Zicer" --parse-metadata "uploader:(?P<uploader>.+)(?: - Topic)$" --parse-metadata "%(uploader,channel,creator,artist|null)s:%(uploader)s" --parse-metadata "artist:(?P<meta_album_artist>[^,]+)" --parse-metadata "%(album_artist,meta_album_artist,uploader)s:%(album_artist)s" --parse-metadata "%(release_year,release_date>%Y,upload_date>%Y)s:%(meta_date)s" --parse-metadata "%(album,title)s:%(meta_album)s" -x --audio-format "m4a" -P "/data/user/0/com.deniscerri.ytdl/cache/downloads/812" -S "hasaud,acodec:aac,ext:m4a" --embed-metadata --embed-thumbnail --convert-thumbnails "jpg" -o "%(uploader,channel).30B-%(title).170B.%(ext)s" "https://www.youtube.com/watch?v=3d-FNAgCqbg"

ERROR: [generic] 'рядом' is not a valid URL. Set --default-search "ytsearch" (or run  yt-dlp "ytsearch:рядом" ) to search YouTube
ERROR: [generic] 'с' is not a valid URL. Set --default-search "ytsearch" (or run  yt-dlp "ytsearch:с" ) to search YouTube
ERROR: [generic] 'подростком' is not a valid URL. Set --default-search "ytsearch" (or run  yt-dlp "ytsearch:подростком" ) to search YouTube

It looks like the app missed some quotation in the command? Anyway had to downgrade

(please complete the following information):

zaednasr commented 6 months ago

ok ill push an update asap

zaednasr commented 6 months ago

dm me on telegram, or ill make a new small release

R3cKi7 commented 6 months ago

Sorry to be a pain, I also have this issue with .3 release. mad respect for this app 🔥❤️ thank you for it!

zaednasr commented 6 months ago

No worries. You can go to telegram and get the temporary fix

zaednasr commented 6 months ago

check 1.7.3.1