search

deniscerri / ytdlnis

Android Video/Audio Downloader app using yt-dlp
GNU General Public License v3.0
3.32k stars 117 forks source link

Cache Removed After "Conversion failed!" Error #423

Closed srezasm closed 4 months ago

srezasm commented 4 months ago

Describe the bug Encountered an error twice during the download of a 16GB YouTube video with the following logs:

 -N "3" --trim-filenames "204" --no-mtime --sponsorblock-remove "music_offtopic" --parse-metadata "uploader:(?P<uploader>.+)(?: - Topic)$" --parse-metadata "%(uploader,channel,creator,artist|null)s:%(uploader)s" --sponsorblock-mark "all" --embed-chapters -S "+hasaud,vcodec:h264,acodec:aac" -f "303+140/303+ba/303/b" --embed-subs --sub-langs "en.*,.*-orig" -P "/data/user/0/com.deniscerri.ytdl/cache/downloads/1" -o "%(uploader)s - %(title)s.%(ext)s" --replace-in-metadata "video:title" ".+" "THE LAST OF US 2 Full Gameplay Walkthrough / No Commentary 【FULL GAME】4K 60FPS Ultra HD" --replace-in-metadata "video:uploader" ".+" "Gamer's Little Playground" "https://youtu.be/4u_Gg0vM9hc?si=upJJKjsX6-yC2ka7"

WARNING: [youtube] Failed to download m3u8 information: HTTP Error 429: Too Many Requests
ERROR:  [download] Got error: _ssl.c:1091: The handshake operation timed out. Giving up after 10 retries

However, after the first error, the download was successfully resumed from the point of failure:

 -N "3" --trim-filenames "204" --no-mtime --sponsorblock-remove "music_offtopic" --parse-metadata "uploader:(?P<uploader>.+)(?: - Topic)$" --parse-metadata "%(uploader,channel,creator,artist|null)s:%(uploader)s" --sponsorblock-mark "all" --embed-chapters -S "+hasaud,vcodec:h264,acodec:aac" -f "303+140/303+ba/303/b" --embed-subs --sub-langs "en.*,.*-orig" -P "/data/user/0/com.deniscerri.ytdl/cache/downloads/1" -o "%(uploader)s - %(title)s.%(ext)s" --replace-in-metadata "video:title" ".+" "THE LAST OF US 2 Full Gameplay Walkthrough / No Commentary 【FULL GAME】4K 60FPS Ultra HD" --replace-in-metadata "video:uploader" ".+" "Gamer's Little Playground" "https://youtu.be/4u_Gg0vM9hc?si=upJJKjsX6-yC2ka7"

WARNING: [youtube] Failed to download m3u8 information: HTTP Error 429: Too Many Requests
ERROR: Postprocessing: Conversion failed!

But the second time, the cache was unexpectedly removed near the end of the download, making it impractical to restart the process due to the time it took to make it there.

To Reproduce Use the provided commands in the log, but additional information can be provided upon request.

Expected behavior The cached video should not be removed due to this error

(please complete the following information):

zaednasr commented 4 months ago

If it was near the end then the app would be trying to merge the parts together then the error showed up but the parts would then be all over the place.

It can't be helped. Just bad timing