deniscerri / ytdlnis

Android Video/Audio Downloader app using yt-dlp
GNU General Public License v3.0
3.32k stars 117 forks source link

[BUG]Multiple downloads, when one of them is paused, the synchronization of other progress becomes invalid #434

Closed leeblackc closed 4 months ago

leeblackc commented 4 months ago

** Before making an issue make sure you are using the latest version of yt-dlp in the settings. Perhaps try using the nightly version of yt-dlp. If that didn't help, proceed with the issue

Describe the bug Multiple downloads, when one of them is paused, the synchronization of other progress becomes invalid

To Reproduce 1.Set the number of downloads to be greater than 1 2.Open two download tasks 3.When the task starts downloading, pause one of them, logcat can see Ignoring setProgressAsync (...), the progress of the notification bar is updated normally, and the progress bar of ActiveDownloadsFragment stops updating

Expected behavior When canceling one of the tasks, the progress of the other tasks is synchronized normally

Screenshots / Video Recording https://github.com/deniscerri/ytdlnis/assets/21374847/4c6fb562-89bd-47b9-a387-c21df85decc9

(please complete the following information):

Additional context I have tested on multiple devices and without any surprise, I have discovered this bug. ytdlnis is a great application, and I hope it will be even better

zaednasr commented 4 months ago

Might be a remnant of old code somewhere, because before every download had its own download worker, but now they are all in a single one. Will check. Thanks for this

zaednasr commented 4 months ago

pull the latest commit and test please

leeblackc commented 4 months ago

Thank you for your reply. It is now working normally