deniscerri / ytdlnis

Android Video/Audio Downloader app using yt-dlp
GNU General Public License v3.0
3.31k stars 117 forks source link

[BUG] downloading from YouTube video player forces PiP mode #442

Closed Dima793 closed 4 months ago

Dima793 commented 4 months ago

Description Tried to use YTDLnis as an external downloader for YouTube ReVanced. When pressing download button in video player screen YTDLnis pops up normally, but also forces the video into Picture-in-Picture mode. Did not happen with PowerTube that I've been using earlier.

Reproduction steps

  1. Set up and open YouTube ReVanced app
  2. Set YTDLnis as external downloader
  3. Play any video in YouTube ReVanced
  4. Press "download" button

Expected behavior YTDLnis should open "on top of" YouTube app that should continue to play the video in the same mode, see PowerTube examplary screenshot.

Screenshots / Video Recording Screen recording of YTDLnis forcing video player into PiP mode: https://github.com/deniscerri/ytdlnis/assets/17815003/7689ba84-8bcb-40a2-8955-c26027146cf3 Examplary screenshot with PowerTube of how it should work (PowerTube screen "on top of" YouTube ReVanced app that plays the video): Screenshot_20240329-042057_PowerTube

Software and hardware information:

zaednasr commented 4 months ago

I believe i have a solution ready. Revanced root works ok and the default share menu works ok. normal revanced with hook btn pulls pip but i believe its an issue with the download hook button.

zaednasr commented 4 months ago

check 1.7.4