[BUG] ytdlnis ignores my format importance order and selects 360p vp9 video

[soredake]

** Before making an issue make sure you are using the latest version of yt-dlp in the settings. Perhaps try using the nightly version of yt-dlp. If that didn't help, proceed with the issue

Describe the bug I set preferred quality to 1080p and preferred video codec to vp9, format importance set to this:

Despite format importance set to prefer video quality and then video codec ytdlnis selects vp9 360p video with this https://youtu.be/pQlF1M8WYx4 video.

To Reproduce Upgrade to latest version, set preferred quality to 1080p, preferred video codec to vp9 and format importance to prefer quality to video codec.

Expected behavior It should select the something in the first three formats, not the fourth:

Screenshots / Video Recording https://github.com/deniscerri/ytdlnis/assets/5204968/5bd5e9b1-9e76-463a-86e2-8f4382cc7f4a

(please complete the following information):

• Android Version: 14
• App Version: 1.7.6
• Other Device Information:

Additional context Add any other context about the problem here.

[zaednasr]

There will never be a smooth release i guess 😭. Will look into it

[zaednasr]

What needs to be done is to adjust the importance quota. Because it looks like the 360p fulfills 2 criteria

1. <= 1080p
2. vp9 codec

while the 720s only fulfil 1 But those two less important quotas sum up a greater value than 1. Thats why this happens The problem is that no matter what 360 will be chosen because even if i make number 1 be 100x more important than number 2, 360 still fulfills 1

[soredake]

Even if I put codec to bottom, it will still select 360p vp9.

[zaednasr]

@soredake buddy, i found time to look into this and i think i figured it out. Can you dm me on telegram so i can send you an apk? Test it out with different preferences and see if its working correctly

[soredake]

@zaednasr sure https://t.me/tttttttttodttttttttt

[zaednasr]

@soredake dm'd you

[zaednasr]

check out 1.7.8