search

denischevalier / StalysVCVPlugin

House of Stalys VCV Plugin
Other
5 stars 2 forks source link

Revert "Performance: Use -ffast-math on compile" #76

Closed denischevalier closed 3 years ago

denischevalier commented 3 years ago

This reverts commit 5dda43f15e4028142223002dd66e56a9086020f8.

https://github.com/VCVRack/library/issues/667#issuecomment-744527207

https://github.com/denischevalier/StalysVCVPlugin/blob/main/Makefile#L7 breaks a lot of stuff like std::isfinite(). I'm not sure why it's needed since -funsafe-math-optimizations should cover most reasonable floating point optimization. If it's needed in DSP code, you could add the optimization on a per-function basis with attribute((optimize("-ffast-math"))). But I can't think of a reason why that would improve your code's speed that much.