denisenkom / django-sqlserver

Django backend for MSSQL server using pytds or adodb backend (moved here from https://bitbucket.org/cramm/django-sqlserver)
MIT License
37 stars 15 forks source link

Support for Django 1.11 #13

Closed petrprikryl closed 7 years ago

petrprikryl commented 7 years ago

I'm using this backend on Django 1.10 without any problems. And as Django 1.11 is now out, is there any chance for support?

Tried on Django 1.11 and is seems that client_class is not implemented.

Traceback (most recent call last):
  ...

  File "/project/virtual/local/lib/python2.7/site-packages/django/db/models/query.py", line 50, in __iter__
    compiler = queryset.query.get_compiler(using=db)
  File "/project/virtual/local/lib/python2.7/site-packages/django/db/models/sql/query.py", line 255, in get_compiler
    connection = connections[using]
  File "/project/virtual/local/lib/python2.7/site-packages/django/db/utils.py", line 212, in __getitem__
    conn = backend.DatabaseWrapper(db, alias)
  File "/project/virtual/local/lib/python2.7/site-packages/sqlserver/base.py", line 80, in __init__
    super(DatabaseWrapper, self).__init__(*args, **kwargs)
  File "/project/virtual/local/lib/python2.7/site-packages/sqlserver_ado/base.py", line 184, in __init__
    super(DatabaseWrapper, self).__init__(*args, **kwargs)
  File "/project/virtual/local/lib/python2.7/site-packages/django/db/backends/base/base.py", line 96, in __init__
    self.client = self.client_class(self)
TypeError: 'NoneType' object is not callable
petrprikryl commented 7 years ago

I have just created pull request for this https://github.com/denisenkom/django-sqlserver/pull/14.

danchr commented 7 years ago

Thank you — and I see @denisenkom merged the pull request. Could we perhaps get a release with this?

frague59 commented 7 years ago

+1

denisenkom commented 7 years ago

uploaded new version to pypi https://pypi.python.org/pypi/django-sqlserver/1.11