search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 500 forks source link

add Go 1.16 to the build matrix #648

Closed shogo82148 closed 3 years ago

shogo82148 commented 3 years ago

The build fails due to https://github.com/denisenkom/go-mssqldb/issues/639 https://ci.appveyor.com/project/denisenkom/go-mssqldb/builds/38567703/job/mpadty14o33sx2re

panic: Not implemented [recovered]
    panic: Not implemented
goroutine 2183 [running]:
testing.tRunner.func1.2(0x64b360, 0x742b20)
    c:/go116/src/testing/testing.go:1144 +0x49f
testing.tRunner.func1(0xc000088480)
    c:/go116/src/testing/testing.go:1147 +0x695
panic(0x64b360, 0x742b20)
    c:/go116/src/runtime/panic.go:971 +0x49a
github.com/denisenkom/go-mssqldb.passthroughConn.SetWriteDeadline(...)
    C:/gopath/src/github.com/denisenkom/go-mssqldb/net.go:167
crypto/tls.(*Conn).SetWriteDeadline(...)
    c:/go116/src/crypto/tls/conn.go:150
(snip)

https://github.com/denisenkom/go-mssqldb/pull/642 maybe fix it.

robinknaapen commented 3 years ago

I've added Go116 pipeline to https://github.com/denisenkom/go-mssqldb/pull/642

denisenkom commented 3 years ago

This is done in a different PR