search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

fix lint warnings #658

Closed shogo82148 closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #658 (c094ad1) into master (d9abbec) will decrease coverage by 0.05%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   72.33%   72.28%   -0.06%     
==========================================
  Files          24       24              
  Lines        5469     5469              
==========================================
- Hits         3956     3953       -3     
- Misses       1289     1291       +2     
- Partials      224      225       +1
Impacted Files Coverage Δ
tds.go 66.83% <0.00%> (-0.39%) :arrow_down:
token.go 60.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9abbec...c094ad1. Read the comment docs.

denisenkom commented 3 years ago

Is it possible to plug in lint to automated PR validator?

shogo82148 commented 3 years ago

reviewdog helps it. https://github.com/denisenkom/go-mssqldb/blob/master/.github/workflows/reviewdog.yml reviewdog validates the changes of pull request, and warns next time. it doesn't validate the whole of the code because it may be very noisy. so at first, we need to fix warnings manually.