search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

Don't check Stmt.processExec errors twice #662

Closed nwwdles closed 3 years ago

nwwdles commented 3 years ago

Hello!

I'm having the same panic: driver.ErrBadConn in checkBadConn. This should not happen as #536, except with Stmt.exec.

This is the same fix as #583.

codecov[bot] commented 3 years ago

Codecov Report

Merging #662 (90904cb) into master (3516239) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   72.28%   72.28%           
=======================================
  Files          24       24           
  Lines        5469     5469           
=======================================
  Hits         3953     3953           
  Misses       1291     1291           
  Partials      225      225
Impacted Files Coverage Δ
mssql.go 87.42% <100.00%> (ø)
tds.go 66.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3516239...90904cb. Read the comment docs.

serbrech commented 3 years ago

lgtm