search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

Fix issue where login errors are not returned as mssql.Error #670

Closed coquagli closed 3 years ago

coquagli commented 3 years ago

Fixes #653.

Login errors don't get returned as mssql.Error. Instead they are returned as plain old error. This is due to a snippet in tds.go that removes the typing of the error message in order to preface the error with "login error: ". This PR adjusts that snippet to return mssql.Error while still maintaining the "login error: " prefix.

codecov[bot] commented 3 years ago

Codecov Report

Merging #670 (b8786e4) into master (3516239) will decrease coverage by 0.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   72.28%   72.10%   -0.18%     
==========================================
  Files          24       24              
  Lines        5469     5471       +2     
==========================================
- Hits         3953     3945       -8     
- Misses       1291     1297       +6     
- Partials      225      229       +4
Impacted Files Coverage Δ
tds.go 66.15% <100.00%> (-0.68%) :arrow_down:
token.go 60.28% <0.00%> (-0.64%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3516239...b8786e4. Read the comment docs.