search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

Fix datetime test #671

Closed tc-hib closed 3 years ago

tc-hib commented 3 years ago

A test fails on my computer, because my language does not have the right default datetime format. This tiny PR fixes it by using a format that works everywhere.

You can test that in SSMS using this query:

set language us_english
select cast('2014-06-26 11:08:09.673' as datetime)
select cast('2014-06-26T11:08:09.673' as datetime)
set language french
select cast('2014-06-26 11:08:09.673' as datetime)
select cast('2014-06-26T11:08:09.673' as datetime)
codecov[bot] commented 3 years ago

Codecov Report

Merging #671 (1e9e37f) into master (74bac08) will decrease coverage by 0.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   70.26%   70.13%   -0.14%     
==========================================
  Files          23       23              
  Lines        5146     5146              
==========================================
- Hits         3616     3609       -7     
- Misses       1304     1308       +4     
- Partials      226      229       +3
Impacted Files Coverage Δ
token.go 60.28% <0.00%> (-0.64%) :arrow_down:
tds.go 65.76% <0.00%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74bac08...1e9e37f. Read the comment docs.