search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

Don't send attention during login #682

Closed shueybubbles closed 3 years ago

shueybubbles commented 3 years ago

I saw test failures per issue #679 due to higher latency connections to my servers. The error should have been DeadlineExceeded but it was getting a spurious did not get cancellation confirmation.

The fix is to instruct the reader not to send attention during ctx->done() handling during the login processing. Along the way I fixed the set language test that was failing on my server, which has a case sensitive collation.

shueybubbles commented 3 years ago

looks like I need to learn git version kungfu :-)

codecov[bot] commented 3 years ago

Codecov Report

Merging #682 (81b8118) into master (9e2f833) will increase coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   70.25%   70.39%   +0.14%     
==========================================
  Files          23       23              
  Lines        5174     5179       +5     
==========================================
+ Hits         3635     3646      +11     
+ Misses       1310     1306       -4     
+ Partials      229      227       -2
Impacted Files Coverage Δ
tds.go 66.05% <100.00%> (+0.82%) :arrow_up:
token.go 61.41% <100.00%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e2f833...81b8118. Read the comment docs.