search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

SetWriteDeadline "not implemented" panic #688

Open wizofaus opened 3 years ago

wizofaus commented 3 years ago

Hi, We're using an older version of this in an AWS lambda and just today we started getting "not implemented" panics when closing DB connections. Nothing was changed in our code. I can see these "not implemented" panics have been removed in the latest version, so is there any reason not to upgrade? Would you have any clue why this would just start happening now (also, they don't happen on all our environments, but do happen in production, which is using RDS etc.) It's true we deployed new binary builds of our lambdas recently, but we certainly didn't change any source code. Thanks!

tc-hib commented 3 years ago

Have you seen #639?

wizofaus commented 3 years ago

Actually I did, but just skimmed through it, on re-reading it in more detail it makes sense now - it's very likely the go compiler got updated on our build servers since our last version was built. Just annoying we only spotted it in production (but thankfully it didn't result in a customer-facing error).

berndverst commented 3 years ago

Update your go.mod and make sure to use this version - this is the commit corresponding to the latest tag:

github.com/denisenkom/go-mssqldb v0.0.0-20210411162248-d9abbec934ba
wizofaus commented 3 years ago

Yeah have done so, seems fine. Interestingly in AWS it only crashes when it's using RDS, vs an ec2 instance running SQL server (our non-profit set-up).

berndverst commented 3 years ago

@wizofaus FWIW it also crashed with Azure SQL Server -- couldn't quickly verify whether it crashed with the Docker images because they won't run on M1 Macs.