search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 495 forks source link

keep tls config in sync with msdsn host #695

Closed shueybubbles closed 2 years ago

shueybubbles commented 2 years ago

Fixes #482 p.TLSConfig here is a pointer back to the original config, so we shouldn't overwrite its contents in this retry loop. Otherwise the TLSConfig.ServerName doesn't match p.Host on new connections for the first Handshake call.

@kardianos once this is in can you create a 0.10.1 release for the AKS team at Microsoft to consume? They want to pick up an official release with the fixes for bad connection marking.

shueybubbles commented 2 years ago

@denisenkom @kardianos hi can we get this change reviewed and merged soon? It's a regression introduced when the msdsn package was added.

gambtho commented 2 years ago

would love to see this get merged, it's preventing us to upgrading to a newer version

a new release would be great also!