search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.81k stars 493 forks source link

Fix: Include Instance into LOGIN7 ServerName field #712

Closed srdan-bozovic-msft closed 2 years ago

srdan-bozovic-msft commented 2 years ago

Although this is not explicitly specified drivers do include Instance into LOGIN7 ServerName field and AzureSQL relies on this in certain scenarios (if not included connections will fail).

This is discovered during the follow-up discussion related to #707

codecov[bot] commented 2 years ago

Codecov Report

Merging #712 (25b1d44) into master (73c014a) will decrease coverage by 0.15%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   71.10%   70.94%   -0.16%     
==========================================
  Files          24       24              
  Lines        5202     5208       +6     
==========================================
- Hits         3699     3695       -4     
- Misses       1280     1285       +5     
- Partials      223      228       +5
Impacted Files Coverage Δ
tds.go 65.09% <57.14%> (-0.48%) :arrow_down:
token.go 61.22% <0.00%> (-0.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73c014a...25b1d44. Read the comment docs.