search

denisenkom / go-mssqldb

Microsoft SQL server driver written in go language
BSD 3-Clause "New" or "Revised" License
1.82k stars 499 forks source link

update to azidentity 0.13.1 #722

Closed gambtho closed 2 years ago

gambtho commented 2 years ago

adds support for using azidentity with resourceID - https://github.com/denisenkom/go-mssqldb/issues/721

codecov[bot] commented 2 years ago

Codecov Report

Merging #722 (1128756) into master (e538731) will decrease coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   71.29%   71.24%   -0.06%     
==========================================
  Files          24       24              
  Lines        5386     5386              
==========================================
- Hits         3840     3837       -3     
- Misses       1301     1303       +2     
- Partials      245      246       +1
Impacted Files Coverage Δ
tds.go 65.49% <0.00%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e538731...1128756. Read the comment docs.

gambtho commented 2 years ago

codecov changes don't appear related to the files I changed

gambtho commented 2 years ago

@kardianos would you mind to review this also? it's an update of https://github.com/denisenkom/go-mssqldb/pull/698 which you approved in Jan

shueybubbles commented 2 years ago

you could clone the issue and the PR in github.com/microsoft/go-mssqldb Our fork is live now.