search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
192 stars 53 forks source link

Kerberos support #103

Closed denisenkom closed 4 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #103 into master will decrease coverage by 0.34%. The diff coverage is 38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   94.02%   93.68%   -0.35%     
==========================================
  Files          26       26              
  Lines        7866     7915      +49     
==========================================
+ Hits         7396     7415      +19     
- Misses        470      500      +30
Impacted Files Coverage Δ
tests/connected_test.py 98.14% <100%> (+0.02%) :arrow_up:
src/pytds/login.py 62.1% <15.15%> (-23.38%) :arrow_down:
src/pytds/__init__.py 92.69% <70%> (-0.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4538975...0af7538. Read the comment docs.

dwink commented 5 years ago

Just tested this and it works great! One nitpick though: the spn = “MSSQLSrv@{}:{}” pattern forces the user to pass a port. Otherwise the colon is left dangling. Suggest making it “MSSQLSrv@{}” and appending “:{}” if parsed_servers[0][1] is not None.

Anyhow, would love to see this merged!