Closed denisenkom closed 4 years ago
Just tested this and it works great! One nitpick though: the spn = “MSSQLSrv@{}:{}” pattern forces the user to pass a port. Otherwise the colon is left dangling. Suggest making it “MSSQLSrv@{}” and appending “:{}” if parsed_servers[0][1] is not None.
Anyhow, would love to see this merged!
Codecov Report
98.14% <100%> (+0.02%)
62.1% <15.15%> (-23.38%)
92.69% <70%> (-0.33%)
Continue to review full report at Codecov.