denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
192 stars 53 forks source link

Fix for 'DeprecationWarning: invalid escape sequence \<' #109

Closed quinox closed 4 years ago

quinox commented 4 years ago

The pydoc for connect contains an invalid Python escape sequence. This throws a warning on screen when running with PYTHONWARNINGS="default".

An alternative fix would be to mark the whole text as a string literal: r"""<host>[\<instance>]""" does not show any warnings either.

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files          26       26           
  Lines        7890     7890           
=======================================
  Hits         7405     7405           
  Misses        485      485
Impacted Files Coverage Δ
src/pytds/__init__.py 91.75% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b1d9d2...c45e07f. Read the comment docs.

denisenkom commented 4 years ago

merged, thank you