denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
190 stars 52 forks source link

feat: add support for passing in SSL socket to connect function #120

Closed shubha-rajan closed 3 years ago

shubha-rajan commented 3 years ago

fixes #119

shubha-rajan commented 3 years ago

Hi @denisenkom, can you please take a look at this and help me get the build passing? Happy to work with you on any changes that need to be made. Thanks!

denisenkom commented 3 years ago

Hi @shubha-rajan, can you rebase your change against latest master branch

shubha-rajan commented 3 years ago

Hi @shubha-rajan, can you rebase your change against latest master branch

Done! Looks like tests are passing now. Thanks.

codecov[bot] commented 3 years ago

Codecov Report

Merging #120 (668b41a) into master (7a36f9d) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          28       28           
  Lines        7946     7947    +1     
=======================================
+ Hits         7436     7437    +1     
  Misses        510      510           
Impacted Files Coverage Δ
src/pytds/__init__.py 92.43% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a36f9d...668b41a. Read the comment docs.

shubha-rajan commented 3 years ago

@denisenkom Once this is is merged, can you push a new release so we can use all the new features from the last year? Thanks in advance!

denisenkom commented 3 years ago

How did you test this change?

shubha-rajan commented 3 years ago

How did you test this change?

I'm using the change to pass in a socket wrapped with a custom SSLContext object here: https://github.com/GoogleCloudPlatform/cloud-sql-python-connector/pull/57/files#diff-c11697acd4731dd8e801d4096039cb866c51b15df1ddf3bb68bcc69d8e714342R592

I can add tests to this PR too, if needed.