search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
190 stars 52 forks source link

Update tds.py #127

Closed niconil closed 1 year ago

niconil commented 3 years ago

Fix #117 : this allows programs using this module to have control on logging messages from pytds.

codecov[bot] commented 3 years ago

Codecov Report

Merging #127 (b7514ec) into master (7c73812) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          28       28           
  Lines        7947     7947           
=======================================
  Hits         7437     7437           
  Misses        510      510
Impacted Files Coverage Δ
src/pytds/tds.py 96.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c73812...b7514ec. Read the comment docs.

akachroo762 commented 1 year ago

Can we merge this change?? Due to this not being present, you can't disable logging completely from pytds and lots of useless logs show up

image

niconil commented 1 year ago

what can we do to merge this change ? no activity on this repo since May 2021 !

tpow commented 1 year ago

@denisenkom Can you please review and merge this and make a new release? This is causing pain for many of us using logging and looks like a simple oversight. Thanks! Tim

denisenkom commented 1 year ago

Thank you for the PR! I will try to release new version this weekend

denisenkom commented 1 year ago

New version is released: https://pypi.org/project/python-tds/1.12.0/