search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
191 stars 53 forks source link

Migrate ntlm-auth to pyspnego #156

Closed mariusdkm closed 11 months ago

mariusdkm commented 11 months ago

I think this library should be migrated to pyspnego and away from ntlm-auth because ntlm-auth doesn't get any more updates and the readme states that one should switch. NTLM requests also migrated this year https://github.com/requests/requests-ntlm/pull/126.

mariusdkm commented 11 months ago

This is partly because ntlm-auth uses the hashlib md4 hashing algorithm, which is no longer available in newer versions. pyspnego uses its own implementation. I would be open to making a PR to fix this issue if that is wished for.

denisenkom commented 11 months ago

This is already done, take a look: https://github.com/denisenkom/pytds/issues/154

mariusdkm commented 11 months ago

Ah, alright, thanks.