Closed jackwotherspoon closed 7 months ago
@denisenkom let me know if you think this change is acceptable 😄
Could also use a version.py
instead and read from it as an option
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
ccd0fca
) 89.21% compared to head (d5dbce0
) 89.19%.
Files | Patch % | Lines |
---|---|---|
src/pytds/utils.py | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yeah, I think this is good. I am thinking in future to simplify it more. The idea is to inject a version as part of a build process, so that during runtime it would be just a constant.
Thanks @denisenkom! Just curious when the next release is scheduled be cut so that this change takes effect? 🚀
Some time in January 2024
pkg_resources
is vastly seen as deprecated and in the latest Python version it has been removed entirely from being pre-installed as part of Python https://github.com/python/cpython/issues/95299This results in the following error with Python 3.12 when using pytds:
To fix this we can leverage
importlib.metadata
as a replacement forpkg_resources.get_distribution().version