Closed deronnax closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b04d08e
) 89.13% compared to head (815174f
) 89.13%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good, thanks!
Invoking directly setup.py is deprecated (Why you shouldn't invoke setup.py directly). Plus, this old way of doing only produces sdist and not wheels, which are more modern, the norm now and way more faster to install (I noticed pytds was using the old way because PDM on my project was taking longer to install pytds).
This is a slight change and it's the "good" way to do it "today". I am available if you have more questions.