Open bowleri opened 3 months ago
Attention: Patch coverage is 95.37572%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 89.19%. Comparing base (
585547b
) to head (ea3f618
).
Files | Patch % | Lines |
---|---|---|
src/pytds/tds_session.py | 95.18% | 4 Missing :warning: |
tests/all_test.py | 33.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Appveyor update of ruff from ruff-0.5.1 to ruff-0.5.3 has created failures in tds_types.py
Hi @bowleri, thank you for this pull request. I have some questions below.
How can I test this? Maybe you can give me a simple example script that generates access token and nonce, that I could then use against my test Azure account.
It also seems couple validations are missing, can you add those validations?:
I noticed that you convert access_token into ASCII byte string, this assumes that access_token contains only ASCII characters. Is this assumption safe?
Fixes #135