search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
191 stars 53 forks source link

Tweak escaping of percent signs for SQLAlchemy #172

Closed gordthompson closed 2 months ago

gordthompson commented 2 months ago

Fixes: #171

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.38%. Comparing base (c186dec) to head (6a0a006). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #172 +/- ## ========================================== - Coverage 89.38% 89.38% -0.01% ========================================== Files 45 44 -1 Lines 8092 8090 -2 ========================================== - Hits 7233 7231 -2 Misses 859 859 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

denisenkom commented 2 months ago

Can you add a test case that covers this change?

gordthompson commented 2 months ago

Can you add a test case that covers this change?

Done.

denisenkom commented 2 months ago

@m32 does this change look good to you?

m32 commented 2 months ago

LGTM I've tried this topic several times and I couldn't handle it, respect

SQLAlchemy==2.0.31 tests with pytds

before this change: 50 failed, 706 passed, 777 skipped, 1 warning after: 30 failed, 737 passed, 777 skipped, 1 warning