search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
192 stars 53 forks source link

Update login.py #80

Closed susodapop closed 6 years ago

susodapop commented 6 years ago

Added keyword argument for NTLM Auth domain. The hardcoded 'workspace' does not work on MacOS. This isn't a breaking change -- it preserves existing library behavior but is now more flexible without modifying the library code for each Windows domain.

codecov[bot] commented 6 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          27       27           
  Lines        7914     7914           
=======================================
  Hits         6709     6709           
  Misses       1205     1205
Impacted Files Coverage Δ
src/pytds/login.py 67.92% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9257a6b...ffb9534. Read the comment docs.

denisenkom commented 6 years ago

You can already pass domain by using following format in user name parameter:

domain\user

See line 103: https://github.com/denisenkom/pytds/pull/80/files#diff-e9fa4e0c7153c989d911809365e04363L103