Closed LHCGreg closed 6 years ago
Merging #88 into master will increase coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 93.86% 93.87% +<.01%
==========================================
Files 26 26
Lines 7797 7804 +7
==========================================
+ Hits 7319 7326 +7
Misses 478 478
Impacted Files | Coverage Δ | |
---|---|---|
tests/connected_test.py | 98.53% <100%> (+0.01%) |
:arrow_up: |
src/pytds/__init__.py | 92.91% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0cdf606...90603f8. Read the comment docs.
Looks good, thanks!
It is interesting why tests failed for you. Which Python version did you use?
3.6, running on Windows.
This allows having destination column names that are SQL keywords, such as User.
Fixes #87.
By the way, it was not clear to me how to run the tests. docs/index.rst says to use tox after setting some environment variables but I wasn't able to get that to work, getting "ModuleNotFoundError: No module named 'pytest'", even though I was in a virtualenv that does have pytest installed. I'm not very familiar with Python testing frameworks so maybe I'm doing something wrong.
I was able to run tests/connected_test.py with pytest but got 5 failures before I even made any changes. The test that I wrote passes after the change at least.