denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
192 stars 53 forks source link

Handle decimals correctly even with default decimal context precision. #94

Closed LHCGreg closed 6 years ago

LHCGreg commented 6 years ago

This has the side effect of fixing integration test failures when testing connected_test.py by itself. getcontext().prec = 38 was run in all_test.py which gets run before connected_test.py if you are running all tests, but does not get run if you are only running tests in connected_test.py.

Fixes #90

codecov[bot] commented 6 years ago

Codecov Report

Merging #94 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   94.02%   94.02%   +<.01%     
==========================================
  Files          26       26              
  Lines        7818     7819       +1     
==========================================
+ Hits         7351     7352       +1     
  Misses        467      467
Impacted Files Coverage Δ
tests/all_test.py 95.06% <ø> (-0.01%) :arrow_down:
src/pytds/tds_types.py 92.98% <100%> (ø) :arrow_up:
tests/connected_test.py 98.55% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e11fffd...f3817e5. Read the comment docs.

denisenkom commented 6 years ago

Thanks!