search

denisidoro / navi

An interactive cheatsheet tool for the command-line
Apache License 2.0
14.63k stars 491 forks source link

Fix multiple paths: define the platform-specific join separator #840

Closed zjp-CN closed 7 months ago

zjp-CN commented 1 year ago

fix https://github.com/denisidoro/navi/issues/576

welcome[bot] commented 1 year ago

Thanks for opening this pull request!

zjp-CN commented 1 year ago

But the preview is broken too in debug mode. 20230513220046

The path is not right. 20230513213140

I think it's related to https://github.com/rust-lang/rust/issues/99931 and https://github.com/rust-lang/rust/issues/59117

denisidoro commented 9 months ago

@zjp-CN sorry for taking so long to review this. I'm not able to test this on a Windows machine. Is this a change you're comfortable with landing?

jackandroselv commented 9 months ago

您好！您的邮件我已收到，我会尽快的查阅邮件。谢谢您的来信！

zjp-CN commented 9 months ago

Is this a change you're comfortable with landing?

Yes, I use the compiled navi based on this PR on Windows all the time, and it works fine.

This PR mainly fixes the path parsing on Windows (so nothing changes on Linux), and introduces tracing for logging.

welcome[bot] commented 7 months ago

Congrats on merging your first pull request!