denisidoro / navi

An interactive cheatsheet tool for the command-line
Apache License 2.0
14.61k stars 489 forks source link

Respect FZF fg colors or disable text coloring entirely #858

Open tjex opened 8 months ago

tjex commented 8 months ago

Navi colors the foreground text of each column, regardless of fzf env settings or navi fzf overrides.

navi --fzf-overrides '--color=fg:217' and navi --fzf-overrides '--color=fg:+217' have no effect, while navi --fzf-overrides '--color=bg:217' will

(--color=hl+:217 also does not work, but color=hl:217 does)

I've tested these also via zsh environment variables.

Describe the solution you'd like

An option to disable foreground coloring completely by navi. Or for navi to respect the fg opts of fzf.

Not as optimal, but setting fg+ via config.yaml would also work, and is perhaps easier to implement, as from what I understand the colorinf of the output is default behaviour of the rust terminal package you're using.

There is a significant readability difference in having a different foreground color on selection.

Describe alternatives you've considered I tried fully removing the color parameters in config.yamal but that just sets foreground to default dark blue.

This is how fzf looks for me by default: Screenshot 2023-11-03 at 17 58 46

With navi: Screenshot 2023-11-03 at 17 59 11

welcome[bot] commented 8 months ago

Thanks for opening your first issue here! In case you're facing a bug, please update navi to the latest version first. Maybe the bug is already solved! :)