[BUG] Can't close the window about plugin

[YIRU69]

Hi, thanks for you make the plugin. I have a probrom when I use it. I can't close the window about plugin. What's wrong with it?

[YIRU69]

Hi ,look at the picture.

[denisoed]

@YIRU69 Hi

The plugin does not work correctly in the "Live Preview" mode :( I'll figure it out and fix it

[YIRU69]

@VidathD Hi, friend, this is another error that I said. Step:

1. start to load plugin
2. check the button Run orthography check in the source mode
3. and then the error like the gif.

[YIRU69]

Uncaught TypeError: Cannot read properties of undefined (reading 'getAllMarks')
    at onPopupClose (eval at <anonymous> (app.js:1:1433712), <anonymous>:790:35)
    at e.tryTrigger (app.js:1:838297)
    at e.trigger (app.js:1:838230)
    at OrthographyToggler.setButtonWithRunner (eval at <anonymous> (app.js:1:1433712), <anonymous>:526:24)
    at HTMLButtonElement.toggle (eval at <anonymous> (app.js:1:1433712), <anonymous>:482:20)
onPopupClose @ main.ts:147
e.tryTrigger @ app.js:1
e.trigger @ app.js:1
setButtonWithRunner @ orthographyToggler.ts:107
toggle @ orthographyToggler.ts:56
setTimeout (async)
e.tryTrigger @ app.js:1
e.trigger @ app.js:1
setButtonWithRunner @ orthographyToggler.ts:107
toggle @ orthographyToggler.ts:56

[YIRU69]

Hope you can quickly to fix it. I love you plugin very much.

[denisoed]

@YIRU69 Please, try changing the mode to "Source mode"

[YIRU69]

@YIRU69 Please, try changing the mode to "Source mode"

I am actually on the Source mode!

[denisoed]

@YIRU69 I will fix this bug. Thanks

[YIRU69]

Uncaught TypeError: this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1:1433712), <anonymous>:693:35)

[voidtriangle]

Workaround to close the window.

1. Navigate: \.obsidian\plugins\obsidian-orthography
2. Find file name "main.js"

3. Comment Line or Remove following lines onPopupClose () function

   if (self.activeEditor) self.activeEditor.doc.getAllMarks().forEach((m) => m.clear());

[YIRU69]

@voidtriangle Thanks for you advise. I will test it.

[denisoed]

Fixed