denispeplin / redmine-projects-table

Projects table for Redmine
11 stars 11 forks source link

Syntax error #4

Closed lcharette closed 11 years ago

lcharette commented 11 years ago

First of all, thanks for the plugins. I was looking for something similar for months.

I have the following error after cloning from Github.

Error message:
/usr/share/redmine/plugins/projects_table/lib/projects_table.rb:11: syntax error, unexpected ':', expecting ')' render('table', projects: projects.sort_by(&:lft)) ^ /usr/share/redmine/plugins/projects_table/lib/projects_table.rb:11: syntax error, unexpected ')', expecting kEND

I have latest redmine (from svn checkout) and no other plugins.

denispeplin commented 11 years ago

You probably have ruby 1.8, right?

lcharette commented 11 years ago

Indeed

denispeplin commented 11 years ago

Fixed, get latest version from Github.

And thank for reporting that!

lcharette commented 11 years ago

The error is fixed, but I have a "Redmine 500 error" when attempting to access the projects page. I'll look at why an open another issue.

denispeplin commented 11 years ago

You probably have Redmine's version below 2.1. Those versions are not supported unless somebody will send a fix.

lcharette commented 11 years ago

No, latest Redmine updated from trunk this morning.

Environment:
  Redmine version                          2.2.1.devel.11156
  Ruby version                             1.8.7 (x86_64-linux)
  Rails version                            3.2.11
  Environment                              production
  Database adapter                         MySQL
Redmine plugins:
  projects_table                           0.0.3

Here what's in the log

ActionView::Template::Error (compile error
/usr/share/redmine/plugins/projects_table/app/views/projects/_table.html.erb:17: syntax error, unexpected ':', expecting ')'
...ct.short_description, project: project) if project.descripti...
                              ^
/usr/share/redmine/plugins/projects_table/app/views/projects/_table.html.erb:17: syntax error, unexpected ')', expecting kEND
...project.description.present? );@output_buffer.safe_concat('
                              ^):
    14:           </span>
    15:         </td>
    16:         <td class="wiki description">
    17:           <%= textilizable(project.short_description, project: project) if project.description.present? %>
    18:         </td>
    19:       </tr>
    20:     <% end %>
  app/views/projects/index.html.erb:17:in `_app_views_projects_index_html_erb__917072457_70296152377400'
denispeplin commented 11 years ago

Thats the same issue with the hash syntax.

Could you please fork a repo, fix it and send pull request?

That way we will make sure that all hashes are fixed.

I have no Ruby 1.8 to check.

lcharette commented 11 years ago

Work like a charm now. Thank again for the plugins. Way easier to navigate my long list of projects !

denispeplin commented 11 years ago

Nice, thanks for the fix!