denisprokopchuk / siphon

Automatically exported from code.google.com/p/siphon
0 stars 0 forks source link

Blue GSM Button #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What version of the product are you using? On what operating system?
2.08 (non jailbreak)   2.2.1 3G

Please provide any additional information below.

Hi, 2.08 is great so far, but im not digging the colour scheme of the Blue
GSM button and the Green SIP next to each other, takes away from the nice
siphon keypad GUI

i think the Green SIP is OK but maybe the GSM should be more darker or
greyish similar to skype keypad?

Perhaps the text is to large in the buttons as well?

just my opinion, and thanks for the update, love this app!

Original issue reported on code.google.com by connect...@gmail.com on 9 Apr 2009 at 7:55

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I think that this blue button is not the best way to use GSM call function (not 
nice, take screen space, and not really upgradable).

Perhaps you could use the way that Nokia use for a long time now :
When SIP is "on", and you press the "call" button, they request witch account 
you 
would use to have the call.

Another good thing with that solution is that you'll be able to use the 
multiaccounts for sip facility (when it will be released).

So, in my head, I'll prefere either a UIActionSheet or UIAlertView control to 
handle 
this.
On the settings, add a UISwitch for "Use GSM for calling" to allow people to 
not use 
this function.

- (void)callButtonAction
{
  bool GSM_is_usable = (allowGSMcall && GSM_is_operational);
  if (SIP_is_connected)
  //sip is running
  {
    if ( (! GSM_is_usable) && (! multiaccount_connected))
    {
      // only one SIP is usable, and GSM is not
      // call with the only SIP account that is running
    }
    else
    {
      //add "cancel" to the control
      if (GSM_is_usable)
      {
        //add "GSM" to the control;
      }
      //add all SIP accounts connected to the list
      //Show the control to know connection to use for call;
    }
  }
  else if (GSM_is_usable)
  // no SIP and GSM is usable
  {
    //call directly with GSM
  }
  // here, mean no way to call
}

Original comment by n...@gnld.ch on 11 Apr 2009 at 2:14

GoogleCodeExporter commented 9 years ago
I defined two buttons, to limit the user actions.
But certainly, I should implements this idea and test it.

Original comment by samuelv0...@gmail.com on 11 Apr 2009 at 9:33

GoogleCodeExporter commented 9 years ago
Please keep the buttons seperate... Another step to make a call??? Please no! 
Don't 
make it ask you how you'd like to make a call each time you hit a call button.  
That 
was one of the most annoying things on my N95.

Keep up the great work...

Ajar

Original comment by ajarmol...@gmail.com on 12 Apr 2009 at 3:34

GoogleCodeExporter commented 9 years ago
With this kind of setup, you'll be not requested for hitting a choice if you 
choose 
not to use gsm. So I don't see the problem...

Original comment by n...@gnld.ch on 13 Apr 2009 at 6:27

GoogleCodeExporter commented 9 years ago
Please keep separate buttons .. I beg you .... 

Original comment by mwa...@gmail.com on 24 Apr 2009 at 6:26

GoogleCodeExporter commented 9 years ago
I would be more inclined to use my native phone application for my cellular and 
the 
siphon program for voip only. I am concerned at the possibility of pressing the 
wrong button when making a long distance call, not realizing it, and being 
charged 
for the call.
Otherwise, thanks for the great program that is really straight forward to use.

Original comment by kc.le...@gmail.com on 14 May 2009 at 12:57

GoogleCodeExporter commented 9 years ago
It would be awesome if GSM button could be turned off completely (in settings) 
to avoid 
long-distance charges which may occur by mistake.

Original comment by haltenb...@gmail.com on 29 Jun 2009 at 12:39

GoogleCodeExporter commented 9 years ago
This feature will be enabled in the next version :
http://code.google.com/p/siphon/wiki/Feedback

Original comment by samuelv0...@gmail.com on 29 Jun 2009 at 8:24

GoogleCodeExporter commented 9 years ago
Issue 268 has been merged into this issue.

Original comment by samuelv0...@gmail.com on 30 Jul 2009 at 6:18

GoogleCodeExporter commented 9 years ago
I just uploaded Siphon 2.1.0 rc1 on this site.
http://code.google.com/p/siphon/downloads/list

Original comment by samuelv0...@gmail.com on 3 Sep 2009 at 10:56

GoogleCodeExporter commented 9 years ago
I just uploaded Siphon 2.1.0 rc2 on this site.
http://code.google.com/p/siphon/downloads/list

Original comment by samuelv0...@gmail.com on 5 Sep 2009 at 11:25

GoogleCodeExporter commented 9 years ago
Fixed in 2.1.0rc1

Original comment by samuelv0...@gmail.com on 21 Feb 2010 at 11:27