search

denistakeda / posh

A luxuriously simple and powerful way to make front-ends with DataScript and Reagent in Clojure.
Eclipse Public License 1.0
114 stars 9 forks source link

Rum plugin #6

Closed bamarco closed 4 years ago

bamarco commented 4 years ago

Everything appears to be working. On rum it will always be in cache forever mode because there isn't on-unmount support for derived-atoms.

denistakeda commented 4 years ago

Hello @bamarco and thank you for your PR. Could you please resolve conflicts?

bamarco commented 4 years ago

@denistakeda I don't see any conflicts. It says "This branch has no conflicts with the base branch"

denistakeda commented 4 years ago

@bamarco weird... for me it says "This branch cannot be rebased due to conflicts" And also I can not rebase it, because the code is in your repo. Could you please rebase it to the latest master?

bamarco commented 4 years ago

@denistakeda I've never rebased before. Do you want all the commits squashed?

denistakeda commented 4 years ago

@bamarco no, let them be as is

bamarco commented 4 years ago

@denistakeda I think rebased properly. Try it now.

bamarco commented 4 years ago

Do I need to redo the pr?

denistakeda commented 4 years ago

@bamarco Hm... it still does not allow me to merge because of conflicts. Did you force-push your branch? If yes please redo the PR. Weird things with github today

bamarco commented 4 years ago

redoing pr to accommodate rebase