search

deniszholob / factorio-cheat-sheet

Cheat Sheet for Factorio
https://factoriocheatsheet.com/
GNU General Public License v3.0
256 stars 38 forks source link

Manually added lazy load #398

Closed wormeyman closed 1 month ago

wormeyman commented 2 months ago

Closes #110 Closes #173

When I ran my builds and tested the images lazyloaded just fine, however the videos are not playing for me with oil refining. Can you please double check that?

deniszholob commented 1 month ago

When I ran my builds and tested the images lazyloaded just fine, however the videos are not playing for me with oil refining. Can you please double check that?

Doesnt autoplay for me either, from what i can tell its intentional Maybe lets just only do lazy load for images?

Otherwize some code maybe needed https://medium.com/@bogdanfromkyiv/lazy-load-for-videos-with-plain-js-ef0671dda64 https://www.youtube.com/watch?v=iB59MIAXJ8U

wormeyman commented 1 month ago

Do you want me to just revert the commit that adds lazyloading to videos?

deniszholob commented 1 month ago

Do you want me to just revert the commit that adds lazyloading to videos?

Yeah, lets just keep the scope to images. l made a new ticket for videos #399

wormeyman commented 1 month ago

I reverted the videos commit.