denivip / ios-vast-player

IAB VAST ads playback in iOS AVPlayer
http://blog.denivip.ru/index.php/2012/08/ios-player-with-vast-video-ad-support/?lang=en
MIT License
82 stars 34 forks source link

VAST 2.0 Support — From what I can tell you only supported VAST 1.x #1

Closed stuffmc closed 11 years ago

stuffmc commented 11 years ago

I've modified mostly DVVideoAdServingTemplate+Parsing.m to be able to parse both VAST 1.x as well as 2.0 XMLs. I tested with a VAST XML I have from a Client with an Inline ad in both VAST 1.x and 2.0 variant.

I also have to work on Wrapper for VAST 1.x and 2.0 — You seem to have thought about supporting it (given there is DVWrapperVideoAd — did you get anything done?

kolyuchiy commented 11 years ago

Thanks!

About wrapper ads: no, I haven't done anything yet. I have plans to do so, but unfortunately I'm not sure if I will be able to upload it to github as it is for a paying customer.

stuffmc commented 11 years ago

I have to support Wrapper ads for my paying customer as well. Fortunately my contracts stipulate that I can contribute to such Open Source Projects. Can't you add the Wrapper support without revealing any info about your customer? When would you work on that Wrapper support? I need it in the next 2 to 3 weeks... I'm just willing to spare us a double effort, and you probably know more about it than I do.