search

denji / homebrew-nginx

:fire_engine: Community NGINX tap for custom modules
https://denji.github.io/homebrew-nginx/
Other
616 stars 197 forks source link

openresty-openssl should be keg only #295

Closed felixbuenemann closed 7 years ago

felixbuenemann commented 7 years ago

The formula openresty-openssl should be marked as keg_only so that is is not symlinked into /usr/local. This can be achieved by adding the following to the formula:

keg_only "Only for use with OpenResty"

On my Mac installing ruby-2.4 with rvm failed to detect the homebrew openssl@1.1 install, because the openresty-openssl formula was symlinked and causing the version check in ruby's configure to fail.

denji commented 7 years ago

https://github.com/Homebrew/homebrew-nginx/commit/eb278d62640ad101038a058f017406c703f00901

felixbuenemann commented 7 years ago

@denji Do you think this change warrants a revision bump for the formula? By adding revision 1 clients that do a homebrew upgrade would get the fix now instead of on the next openssl version bump. Of course they can also do brew unlink openresty-openssl to fix it.

denji commented 7 years ago

Send pull-request, revision for rebuild.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.