search

denkmal / denkmal.org

MOVED to GitLab: https://gitlab.com/denkmal/archive/denkmal-2014
MIT License
7 stars 16 forks source link

Genre colour does not apply #724

Closed NicolasSchmutz closed 7 years ago

NicolasSchmutz commented 7 years ago

I added a few new genres (boogie and experimental) to the event-categories but I can't see the colour in the events: https://www.denkmal.org/basel/en/events?date=2017-3-18

Also only rock is underlined from "rock'n'roll" and r'n'r isn't although it's in the list. Has to be an issue with "'".

@njam could you check it before I add more genres?

NicolasSchmutz commented 7 years ago

I added a few new genres (boogie and experimental) to the event-categories but I can't see the colour in the events: https://www.denkmal.org/basel/en/events?date=2017-3-18

It works if there is no space after the comma but not with a space:

screen shot 2017-03-18 at 10 04 05 screen shot 2017-03-18 at 10 04 09
NicolasSchmutz commented 7 years ago

Thx! This is still a issue:

Also only rock is underlined from "rock'n'roll" and r'n'r isn't although it's in the list. Has to be an issue with "'".

Or is this only possible with: https://github.com/denkmal/denkmal.org/issues/671 ?

njam commented 7 years ago

There are different spellings in the event and in the genre:

rock’n’roll
rock'n'roll
NicolasSchmutz commented 7 years ago

I adjusted it but still have the problem. I guess it's because we also have "rock"?

screen shot 2017-03-19 at 16 33 27
NicolasSchmutz commented 7 years ago

It's also a problem for keys with two words like "heavy metal" where we also have "metal" as a single key. Both are handled in https://github.com/denkmal/denkmal.org/issues/671 ?