search

denkyem / home-assistant-moonraker

Integration between Moonraker and Home Assistant
121 stars 20 forks source link

Template formatting, float format both deprecated, missing unique_id #8

Open SirGoodenough opened 1 year ago

SirGoodenough commented 1 year ago

There are several deprecated problems in the yaml code for current HA versions, The Template format is deprecated and will soon break. The use of float without a default is deprecated and causing log errors, and the missing unique_id is confusing people with them not being able to change the temperature units.

I would be open to providing a pull request and work on it if you are interested. I do not run the software, however, and would not be able to test other than test that the YAML syntax is correct. I would ask that you add a dev branch that I could pull against for that reason and so-as not to mess with the customer base.

My interest is in helping the community. I have one 'customer' of yours having problems with temp conversion, and spotted these other things that are causing log issues or will break soon.

UPDATE, PR is done, new template format is provided, please test and merge...

OldCurmudgeon3DP commented 1 year ago

I'll add that while researching to set up my new moonraker install w/ Home Assistant I found a couple of examples on github on how to write the sensor entries. That would indicate that more people than just I will eventually have issues as HA evolves.

davisgoodman commented 1 year ago

There are several deprecated problems in the yaml code for current HA versions, The Template format is deprecated and will soon break. The use of float without a default is deprecated and causing log errors, and the missing unique_id is confusing people with them not being able to change the temperature units.

I would be open to providing a pull request and work on it if you are interested. I do not run the software, however, and would not be able to test other than test that the YAML syntax is correct. I would ask that you add a dev branch that I could pull against for that reason and so-as not to mess with the customer base.

My interest is in helping the community. I have one 'customer' of yours having problems with temp conversion, and spotted these other things that are causing log issues or will break soon.

UPDATE, PR is done, new template format is provided, please test and merge...

Hi,

I have found a condition whereas if If the printed file is within a subdirectory of the gcodes folder, the relative_path used for the thumbails is not the right path. If I go in the Developer tool and change the state of the 3d_printer_object_thumbnails and add the subdirectory in front of it, then the Picture Card displays the thumbnails

I'm not fluent enough in the jinja2 templating to be able to parse the 3d_current_print and extract the subfolder and add it to the 3d_printer_object_thumbnails so that the thumbnails gets displayed

otherwise everything else works