search

denniedegroot / com.ring

Ring for Homey
https://www.athom.com
Other
15 stars 15 forks source link

Fix grab screenshot #27

Closed mapulu closed 4 years ago

mapulu commented 4 years ago

Using bearer and hardware id=cloud id for authentification

denniedegroot commented 4 years ago

Thanks for the pull request! I will take a look at it tonight or tomorrow.

mapulu commented 4 years ago

It still needs some additional steps for checking if the bearer token is still valid. Also taking a new snapshot takes more time then 3x1 second for me

denniedegroot commented 4 years ago

Ah ok, please let me know when you are finished.

mapulu commented 4 years ago

Should be over the next week. Seems the bearer token is only valid for some hours. But that token is needed for taking/grabbing snapshots.

mapulu commented 4 years ago

Finished... It now fetches a new bearer token when not valid for snapshots, might not look so nice but works.

denniedegroot commented 4 years ago

Thanks, I will have a look at it and create a beta version.

denniedegroot commented 4 years ago

I just merged it in the beta branch and did a quick review. Is the login still working because I see you disabled a authorization line? Can you test this? (So logout/login with your Ring credentials.)

mapulu commented 4 years ago

It should still work to login/logout. I will test it. The authorization line does not work anymore so I removed/disabled it. They changed their api. The Bearer token is used instead

denniedegroot commented 4 years ago

Can you test my beta branch just to confirm everything merged well?

mapulu commented 4 years ago

yes after the weekend

SiobhanBaynes commented 4 years ago

Just tested this on the beta branch and it seems to be working great. Did get an error the first time I ran it (log available if you want it) but ran again and all seems fine. Thanks guys 🙂

SiobhanBaynes commented 4 years ago

Raised a PR to fix the error I was seeing. I'm not seeing the image in the Flow to send the notification. I can only see it on the developer portal/

mapulu commented 4 years ago

@SiobhanBaynes did you use for the "image was grabbed" the mobile notification? If you use iOs you also have to enter a text to send.

The PR from @SiobhanBaynes fixes an issue when a valid answer for timestamp was send but no timestamp in it

SiobhanBaynes commented 4 years ago

@mapulu No I wasn't. I was trying to send the image in the same flow that grabbed it. Using the image was grabbed notification it's working fine 👌

mapulu commented 4 years ago

Sending the image in the same flow which grabbed it do not really work. Also the same with the image grabber app.