search

denniedegroot / com.ring

Ring for Homey
https://www.athom.com
Other
15 stars 15 forks source link

refactor on camera/grab image. #55

Closed kaohlive closed 4 years ago

kaohlive commented 4 years ago

Removed now deprecated image.fromBuffer and replaced it with setStream where the stream is not tied to the grabimage api call. This improves the cameraview page so that the refresh button now actually updates the images from the API instead of from memory. The grabImage action now only refreshes the cameraview also, the image grabbed event than takes that images. Cleaner code and more funcitonality with no more deprecated methods.

Also put all this code in the stickupcam device, no idea if it works though, I do not have one.

kaohlive commented 4 years ago

its ready for you to merge this one.

denniedegroot commented 4 years ago

Hi @kaohlive, I cannot merge this one as it has conflicts. Can you rebase based on the master branch?

kaohlive commented 4 years ago

@denniedegroot sorry, git is not my friend. So I messsed up the version again I think. But it says at least there is no merge conflict anymore.

kaohlive commented 4 years ago

just in case it was not clear 😉 i rebased and solved the conflicts. so you should be able to merge.

denniedegroot commented 4 years ago

Thanks again!