search

denniedegroot / com.ring

Ring for Homey
https://www.athom.com
Other
15 stars 15 forks source link

Stickup cam enable/disable motion detection #70

Closed tokreutz closed 3 years ago

tokreutz commented 3 years ago

Was able to reverse engineer the Ring APIs and found the proper Ring endpoint for enabling/disabling motion detection for the stickup cams.

I have validated this with my own Homey and stickup cam, and seems to work as expected.

Should resolve #43

tokreutz commented 3 years ago

@denniedegroot is it possible to get a review on this one?

denniedegroot commented 3 years ago

Hi, thanks for your great work! I see you are working on a better solution based on a different library, am I right?

tokreutz commented 3 years ago

Yes. I want to integrate using the dgrief/ring project. It has most, if not all of Rings APIs covered. Integrating that will take a little time, but I expect we can use that for all Ring interaction over time. Currently working on mode support.

As it might take a while doing that I suggest we complete this PR to get the functionality fixed for the motion detection. I will open new PRs for that as I get more done om that integration. Might need a few more devices also :p

tokreutz commented 3 years ago

@denniedegroot , one question. how did you come across the icons used for the cameras, or did you create them yourself?

edwinvdpol commented 3 years ago

https://github.com/athombv/homey-vectors-public/tree/master/com.ring

tokreutz commented 3 years ago

Thanks @edwinvdpol , but who has created these? What I'm really after is tips for creating an icon for the alarm mode support I'm adding.

edwinvdpol commented 3 years ago

I think Ivo Derksen, as he created all the icons which are found here.

mhoogenbosch commented 3 years ago

If there is anything I can test for you guys to help, I'm would gladly be of service.

tokreutz commented 3 years ago

I have already tested the functionality, and it works as expected. Thanks @mhoogenbosch for the offer. Maybe I can ask for testing assistance for future PRs to this project :)

Just waiting for @denniedegroot to merge the request as I don't have the power to do so myself.

denniedegroot commented 3 years ago

@tokreutz are you maybe willing to take over the app as I don’t have much spare time or Ring devices?

tokreutz commented 3 years ago

@denniedegroot , sure. I can do that :) Is there any formal way of doing so?

denniedegroot commented 3 years ago

@tokreutz I will check how I can do it.

Meanwhile could someone verify if it is working as intended? https://homey.app/a/com.amazon.ring/test/