search

dennisdoomen / CSharpGuidelines

A set of coding guidelines for C# 9.0, design principles and layout rules for improving the overall quality of your code development.
https://www.csharpcodingguidelines.com
Other
746 stars 271 forks source link

Remove ICollection<T> as an allowed interface from AV1130 #216

Closed maikelsteneker closed 4 years ago

maikelsteneker commented 4 years ago

Reasoning: the ICollection interface actually allows one to modify the collection, which goes against the intention of this guideline. The reason for this exception was that versions of .NET Framework before 4.5 did not include immutable collections.

Closes dennisdoomen#215

dennisdoomen commented 4 years ago

Waiting for @bkoelman's approval

bkoelman commented 4 years ago

Looks good to me, thanks.

dennisdoomen commented 4 years ago

Awesome. Thanks for this contribution.