Fix formatting of titles

dennisdoomen / CSharpGuidelines

A set of coding guidelines for C# 9.0, design principles and layout rules for improving the overall quality of your code development.

https://www.csharpcodingguidelines.com

Other

745 stars 272 forks source link

Fix formatting of titles #238

Closed bkoelman closed 2 years ago

bkoelman commented 2 years ago

Moved the title out of its HTML tag so it gets proper formatting and added a leading div to preserve anchors.

Result when running locally:

Fixes #209.

/cc @julianbartel Though this seems to work, perhaps there's a better way. I know nearly nothing about the doc generation process here and I'm open to suggestions, so would be great if can chime in and take a look.

dennisdoomen commented 2 years ago

@bkoelman which Ruby version are you using? I'm using 2.4.10p364, but can't build the site anymore.

bkoelman commented 2 years ago

Oh sorry, I only used build.bat, which produced the HTML files. I don't have Ruby installed. Can you provide some more info on what to download/install from where to build the site? I'm not sure where to go, based on what's in https://github.com/dennisdoomen/CSharpGuidelines/blob/master/README.md.

dennisdoomen commented 2 years ago

Just checked once more on another machine and there it works according to the instructions.

dennisdoomen commented 2 years ago

Hmm, this only fixes the titles in the PDF output. Not the HTML versions.

bkoelman commented 2 years ago

Pushed another commit to fix titles on website pages and in its search results.

dennisdoomen commented 2 years ago

Great work.