search

dennisppaul / wellen

wellen is a framework for exploring and teaching generative music making and algorithmic compositions.
GNU General Public License v3.0
22 stars 2 forks source link

noteOn duration in ms #16

Closed jsr606 closed 3 years ago

jsr606 commented 3 years ago

right now the duration for tones are set in seconds. perhaps milliseconds make more sense?

dennisppaul commented 3 years ago

i d vote against it. all times are spec'd in seconds all across the library. maybe a util method like to_sec(int millis) would help to make the matter more explicit in code.

dennisppaul commented 3 years ago

added to_sec(int pMilliSeconds) and to_millis(float pSeconds) to Wellen. now Tone.note_on(48, 85, to_sec(500)) allows to specify time in milliseconds.